Spelling #6822

jsoref · 2021-03-31T15:34:56Z

I can understand if now isn't the right time for a spelling PR. But, at some point...

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@b6ba3e2#commitcomment-48946465

The action reports that the changes in this PR would make it happy: jsoref@602417c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

NEWS

Zend/Optimizer/block_pass.c

Zend/Optimizer/pass1.c

jsoref · 2021-03-31T15:36:27Z

Zend/Optimizer/zend_dump.c

@@ -926,7 +926,7 @@ ZEND_API void zend_dump_op_array(const zend_op_array *op_array, uint32_t dump_fl
 		}
 	}
 	if (func_flags & ZEND_FUNC_IRREDUCIBLE) {
-		fprintf(stderr, ", irreducable");
+		fprintf(stderr, ", irreducible");


Hopefully debug, but to match the line above...

jsoref · 2021-03-31T15:36:37Z

Zend/Optimizer/zend_optimizer_internal.h

@@ -113,7 +113,7 @@ zend_function *zend_optimizer_get_called_func(
 uint32_t zend_optimizer_classify_function(zend_string *name, uint32_t num_args);
 void zend_optimizer_migrate_jump(zend_op_array *op_array, zend_op *new_opline, zend_op *opline);
 void zend_optimizer_shift_jump(zend_op_array *op_array, zend_op *opline, uint32_t *shiftlist);
-int sccp_optimize_op_array(zend_optimizer_ctx *ctx, zend_op_array *op_arrya, zend_ssa *ssa, zend_call_info **call_map);
+int sccp_optimize_op_array(zend_optimizer_ctx *ctx, zend_op_array *op_array, zend_ssa *ssa, zend_call_info **call_map);


jsoref · 2021-03-31T15:54:20Z

sapi/phpdbg/xml.md

+### stepping ###

 - sets stepping to either opcode or line (so a step command will either advance one op or one line)


I'm not sure how to reconcile this w/ the previous, but it might be the right change

tests/lang/static_basic_001.phpt

tests/security/open_basedir_001.phpt

tests/strings/002.phpt

MaxSem · 2021-04-01T07:38:00Z

Trailing whitespace issue in tests/lang/static_basic_001.phpt

Girgias

Seems mostly fine to me, even the SAPI changes as I imagine they are only internal APIs to the specific module.

main/streams/streams.c

sapi/fpm/fpm/fpm_events.h

Girgias · 2021-04-01T14:15:06Z

sapi/fpm/fpm/fpm_log.c

-					/* miliseconds */
-					} else if (!strcasecmp(format, "miliseconds") || !strcasecmp(format, "mili")) {
+					/* milliseconds */
+					} else if (!strcasecmp(format, "milliseconds") || !strcasecmp(format, "milli")) {


I'm not sure if it is a break, as it might only be called internally so if all other occurrences are fixed should be fine.

tests/strings/002.phpt

tests/security/open_basedir_001.phpt

bukka · 2021-04-01T14:46:05Z

sapi/fpm/fpm/fpm_log.c

-					/* miliseconds */
-					} else if (!strcasecmp(format, "miliseconds") || !strcasecmp(format, "mili")) {
+					/* milliseconds */
+					} else if (!strcasecmp(format, "milliseconds") || !strcasecmp(format, "milli")) {


This is a break. It even breaks the example in the config template: https://gist.github.com/sotarok/2767859#file-php-fpm-conf-L406 (if someone decides to uncomment it) so you need keep the incorrect one. I'm fine if you add a correct one as well and updated that commented line to use the correct one but please keep the old one as this could be a hard to catch break. You can also add comment that the incorrect one is kept just for compatibility reason.

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

This adds milli/milliseconds but retains support for mili/miliseconds Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref · 2021-04-02T07:20:20Z

cmd_parms turns out to be an apache api, so I've dropped that.

nikic

Looks good apart from LSAPI env var change.

nikic · 2021-04-13T10:05:46Z

sapi/litespeed/lscriu.c

@@ -289,9 +289,9 @@ static void LSCRIU_Wink_Server_is_Ready(void)
        // Not used for native
        return;
    }
-    if (getenv("LSAPI_UNIQE"))
+    if (getenv("LSAPI_UNIQUE"))


Yes, better not touch this, especially as we don't maintain this code.

jsoref added 15 commits March 31, 2021 11:04

spelling: abcdefghijklmnopqrstuvwxyz

6a64a4f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: aborting

7eca000

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: abstract

58a0438

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: accepted

58b184e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: additional

590e1c3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: alloca'd

9b5ad50

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: allocated

739afdf

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: ambiguities

d016413

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: and set

6fdcbb6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: anonymous_index

e2ee9e9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: appear

ac43b42

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: append

a4be4d9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: arbitrarily

c65093c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: arithmetic

df6f26e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: array

e29a441

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref commented Mar 31, 2021

View reviewed changes

jsoref force-pushed the spelling branch from f1e83a8 to 47fe4ad Compare March 31, 2021 16:28

Girgias reviewed Apr 1, 2021

View reviewed changes

bukka requested changes Apr 1, 2021

View reviewed changes

jsoref added 10 commits April 1, 2021 11:54

spelling: assignment

a8201aa

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: backtrace

8050e8c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: breakpoint

eb2e230

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: bug

2527176

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: called

580d53d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: certainly

0472362

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: children

26ed0f1

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: collect

5b01545

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: colliding

fffebe3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: combinable

8c24114

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 24 commits April 2, 2021 03:15

spelling: result

7ea5e8c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: results

6bda88d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: rewritten

aa6549f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: setprompt

87f2ee9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: skip

1e82777

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: source

8a474f3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: specified

92a55cf

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: stepping

28093eb

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: stringify

d1bbcb1

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: strlen

289da0c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: structures

a012a14

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: synonym

5b400fa

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: terminates

8167dfe

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: therefore

1a80856

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: typelib

13d5531

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: ugly

cddd4c6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: uninitialized

70bc9fe

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: unqualified

1ed5ea5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: us

469b067

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: visited

fd74a7f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: wrap-up

89c8a4a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: mechanism [API]

8ae474a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: milli [API] fpm_log_write

148b9ac

This adds milli/milliseconds but retains support for mili/miliseconds Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: unique [API]

ed225cb

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from b2b65f4 to ed225cb Compare April 2, 2021 07:16

jsoref requested a review from bukka April 2, 2021 21:09

nikic approved these changes Apr 13, 2021

View reviewed changes

nikic closed this in 462da6e Apr 13, 2021

jsoref deleted the spelling branch April 13, 2021 12:03

		### stepping ###

		- sets stepping to either opcode or line (so a step command will either advance one op or one line)

Spelling #6822

Spelling #6822

Uh oh!

Conversation

jsoref commented Mar 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsoref Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

jsoref Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

jsoref Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaxSem commented Apr 1, 2021

Uh oh!

Girgias left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Girgias Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bukka Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

jsoref commented Apr 2, 2021

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

nikic Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!